Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RegularExpressionTestUtil for testing regexes #1041

Merged
merged 11 commits into from
Jan 24, 2025
Merged

Add RegularExpressionTestUtil for testing regexes #1041

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0d3e61e
Adding regular expression testing utility.
ldhardy Jan 7, 2025
c635a75
Adding a regular expression testing util.
ldhardy Jan 7, 2025
93a6c65
Fixes from testing.
ldhardy Jan 7, 2025
45e8a06
Remove conditional logic for logging and test failure.
ldhardy Jan 8, 2025
fbc9716
Remove dashes from javadoc params.
ldhardy Jan 8, 2025
378738b
update methods in OSReleaseUtil (#1038)
jpdahlke Jan 7, 2025
a7a1aa4
initialize static instance of EmissaryServer (#1024)
jpdahlke Jan 7, 2025
c4bb10d
add support to link a tld to a child IBDO for inheriting parameters (…
rpg36 Jan 8, 2025
6db9164
[github-actions](jpdahlke) next development iteration 8.21.0-SNAPSHOT…
github-actions[bot] Jan 8, 2025
7591b83
Merge branch 'main' into regex-testutil
ldhardy Jan 13, 2025
294cad4
Fixing error prone warnings
ldhardy Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove conditional logic for logging and test failure. 
Co-authored-by: drivenflywheel <dan@drivenflywheel.com>
  • Loading branch information
@ldhardy @drivenflywheel
ldhardy and drivenflywheel authored Jan 8, 2025
commit 45e8a0642660af675b60684c12f51c0efffe1b09
7 changes: 2 additions & 5 deletions src/test/java/emissary/test/util/RegularExpressionTestUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,8 @@ public static void testRegexPattern(Pattern patternUnderTest, @Nullable List<Str
fineGrainTestCount++;
}
}
if (fineGrainTestCount == 0) {
fail("Didn't test anything.");
} else {
logger.debug("Successfully asserted {} regex test cases.", fineGrainTestCount);
}
assertTrue(fineGrainTestCount > 0, "No regex assertions performed.");
logger.debug("Successfully asserted {} regex test cases.", fineGrainTestCount);
}


Expand Down
Loading