Dependency analysis in gitlab #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foster33
reviewed
Nov 21, 2024
pom.xml
Outdated
Comment on lines
28
to
29
| <version.datawave.hazelcast-client>4.0.2</version.datawave.hazelcast-client> | ||
| <version.datawave.hazelcast>4.0.2</version.datawave.hazelcast> |
There was a problem hiding this comment.
We might not want to change this from <version.datawave.hazelcast-client> to <version.datawave.hazelcast>. Seems like we are still using hazelcast-client in the pom.
In the latest standardization of property names effort, hazelcast was actually the one that got renamed to hazelcast-common. hazelcast-client remained unchanged. So, for the sake of consistency we probably don't want to change this. Might mean we need to add another property here.
Unless I am not understanding this correctly. Just wanted to make sure.
There was a problem hiding this comment.
its all good, i created hazelcast & hazelcast-client, both at v 4.0.2.
7bb2d02 to
de8617d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating dependencies for submodule