Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cases that MiSeq samplesheet misses index or index2 #420

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

chuan-wang
Copy link

And some ruff linting.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 21.80%. Comparing base (6d7d339) to head (b5c8feb).

Files Patch % Lines
taca/illumina/Runs.py 0.00% 5 Missing ⚠️
taca/analysis/analysis.py 0.00% 3 Missing ⚠️
taca/illumina/Standard_Runs.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #420   +/-   ##
=======================================
  Coverage   21.79%   21.80%           
=======================================
  Files          28       28           
  Lines        3936     3944    +8     
=======================================
+ Hits          858      860    +2     
- Misses       3078     3084    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sofiahag
Copy link

Wow, you're so fast, Chuan! ⚡

@chuan-wang
Copy link
Author

Wow, you're so fast, Chuan! ⚡

Very tiny change :D

Copy link

@sofiahag sofiahag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me!

@chuan-wang chuan-wang merged commit dde2ba1 into NationalGenomicsInfrastructure:master Mar 26, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants