Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(stark-all): remove greenkeeper-lockfile and obsolete RxJS artifacts. Ban imports from '@angular/material' and 'lodash' root entry points #729

Conversation

christophercr
Copy link
Collaborator

@christophercr christophercr commented Sep 27, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Build related changes
[X] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #585

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[X] No

@christophercr christophercr added this to the 10.0.0-beta.1 milestone Sep 27, 2018
@christophercr christophercr force-pushed the feature/build-enhancements branch from 56ffb58 to 60563f9 Compare September 27, 2018 14:59
@coveralls
Copy link

coveralls commented Sep 27, 2018

Coverage Status

Coverage decreased (-0.02%) to 91.709% when pulling 82bf7ab on christophercr:feature/build-enhancements into 688111d on NationalBankBelgium:master.

…compat' and 'greenkeeper-lockfile' deps. Set tslint 'import-blacklist' rule to prevent imports from '@angular/material' and 'lodash'
@christophercr christophercr force-pushed the feature/build-enhancements branch from 60563f9 to 82bf7ab Compare September 28, 2018 13:03
@christophercr christophercr added type: enhancement comp: stark-build Stark Build comp: stark-all To apply for all Stark modules labels Sep 28, 2018
@christophercr christophercr merged commit 16b6869 into NationalBankBelgium:master Sep 28, 2018
@christophercr christophercr deleted the feature/build-enhancements branch October 1, 2018 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: stark-all To apply for all Stark modules comp: stark-build Stark Build type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants