Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stark-core): implement Stark XSRF module #708

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

christophercr
Copy link
Collaborator

@christophercr christophercr commented Sep 21, 2018

ISSUES CLOSED: #115

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #115

What is the new behavior?

XSRF protection can be enabled now by importing the Stark XSRF module.

In case the Stark XSRF module is imported in the App, then all the Http requests will be sent with withCredentials: true otherwise the browser will not accept the XSRF cookie received from the backend.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

The json-server configuration from the old Stark can be used to test this new feature.

@coveralls
Copy link

coveralls commented Sep 21, 2018

Coverage Status

Coverage decreased (-0.3%) to 91.288% when pulling e82ed0d on christophercr:feature/xsrf into 8a787f7 on NationalBankBelgium:master.

Copy link
Member

@SuperITMan SuperITMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems right

@SuperITMan
Copy link
Member

Can you please rebase it ?

@christophercr
Copy link
Collaborator Author

Rebased ;)

@SuperITMan SuperITMan merged commit 3ceb759 into NationalBankBelgium:master Sep 26, 2018
@christophercr christophercr deleted the feature/xsrf branch September 27, 2018 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: http - xsrf
3 participants