Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(docs): integrate the stark layout in all showcase's pages #701

Merged
merged 1 commit into from
Sep 20, 2018
Merged

style(docs): integrate the stark layout in all showcase's pages #701

merged 1 commit into from
Sep 20, 2018

Conversation

catlabs
Copy link
Contributor

@catlabs catlabs commented Sep 19, 2018 •
edited
Loading

ISSUES CLOSED: #673

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #673

What is the new behavior?

Stark layout is now applied in all pages of the showcase

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@catlabs catlabs added this to the 10.0.0-alpha.6 milestone Sep 19, 2018
@catlabs catlabs self-assigned this Sep 19, 2018
@coveralls
Copy link

coveralls commented Sep 19, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 92.402% when pulling fe56d4d on catlabs:feature/global-layout into cce54ce on NationalBankBelgium:master.

@catlabs catlabs force-pushed the feature/global-layout branch from fa32044 to 6a7b597 Compare September 19, 2018 13:26
christophercr
christophercr reviewed Sep 20, 2018
View reviewed changes
Copy link
Collaborator

@christophercr christophercr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small remarks.

And also, I don't think this PR is related to this issue 668 because the Flex reusable classes are not there yet and there is no documentation stating that they can Angular's FlexLayout. Perhaps we should tackle this in another PR?

showcase/src/assets/translations/en.json
"TITLE": "Stark breadcrumb"
},
"BUTTON": {
"TITLE": "Stark buttons"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put all the titles with the first letter of each word in uppercase? Like "Stark Buttons"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I don't think it is super relevant, title and sentences should be written with normal case, then we can css rule to override this, but at least we can always go back to the original version if we want.
I also considered uppercasing titles but they don't do it neither in Angular Material or in Material Design.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's keep it like this for now 😉

showcase/src/app/demo/date-range-picker/date-range-picker.component.html Outdated
</div>
<mat-checkbox [(ngModel)]="isDisabled">isDisabled</mat-checkbox>
</example-viewer>
<h1 class="mat-display-3" translate>SHOWCASE.DEMO.DATE_PICKER.TITLE</h1>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation key here should be the one from the Date Range picker instead of the one from Date Picker ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted :-)

showcase/src/app/home/home.component.html Outdated
<mat-card-header>
<mat-card-title>
<h1 class="documentation-title">Stark documentation</h1>
<h4 translate>Stark Core - Latest</h4>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the titles of the cards of this Home page, could we have them centered horizontally?

@catlabs catlabs force-pushed the feature/global-layout branch from 6a7b597 to fe56d4d Compare September 20, 2018 09:53
@catlabs
Copy link
Contributor Author

catlabs commented Sep 20, 2018

Rebased and repushed

@christophercr christophercr merged commit 4678ee2 into NationalBankBelgium:master Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophercr christophercr christophercr approved these changes

@SuperITMan SuperITMan Awaiting requested review from SuperITMan

Assignees

@catlabs catlabs

Labels
comp: stark-showcase comp: stark-ui must
Projects
None yet
Milestone
10.0.0-beta.0
Development

Successfully merging this pull request may close these issues.

showcase: global layout - integrate in all pages
3 participants
@catlabs @coveralls @christophercr