Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): added support for publishing api docs and showcase using Travis #416

Closed

Conversation

dsebastien
Copy link
Contributor

Issues closed: #282

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

We generate our docs but don't publish them

Issue Number: #282

What is the new behavior?

We publish the api docs and the showcase on GitHub pages.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

The solution is not complete yet, because other issues need to be tackled for this to be effective; for example #415

@dsebastien
Copy link
Contributor Author

To actually test this, we'll need to create a release.
I also noticed that the current npm packages we publish still refer to ...alpha.2 as the "next", which doesn't make much sense if the next will actually be at least alpha.3 ^^

EXPECTED_NODE_VERSION="8"

COMMIT_AUTHOR_USERNAME="TravisCI"
COMMIT_AUTHOR_EMAIL="seb@dsebastien.net"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not we create a specific email address (NBB) for Stark on GitHub ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but no :)

@SuperITMan
Copy link
Member

SuperITMan commented Jun 5, 2018

Actually, when we do a release, I think we should update the version to the next patch/minor one automatically 😊
Except for now, of course, because we are still in alpha version.

@coveralls
Copy link

coveralls commented Jun 5, 2018

Coverage Status

Coverage remained the same at 94.247% when pulling 5d53f7a on dsebastien:feature/ghdeploy into 69ee8f4 on NationalBankBelgium:master.

@dsebastien
Copy link
Contributor Author

@christophercr, @RobbyDeLaet I leave this up to you guys :)
I think you could test the push operation from Robby's laptop.
If the script doesn't work now, it probably means that the SSH key ain't used.

Here's the alternative I had found: https://gist.github.com/douglasduteil/5525750

@christophercr
Copy link
Collaborator

This could be another alternative: https://gist.github.com/willprice/e07efd73fb7f13f917ea

@christophercr
Copy link
Collaborator

@dsebastien I tested again this and indeed the SSH key wasn't used when doing the git clone/push.

So I used the other alternative you mentioned, and that works, this is the log of the successful build of my fork: https://travis-ci.org/christophercr/stark/jobs/393357177

I've adapted my fork so you can see the changes I did compared to what you have (but you need to rebase yours with the latest changes from the master): dsebastien/stark@feature/ghdeploy...christophercr:feature/ghdeploy

@dsebastien
Copy link
Contributor Author

Great!

Don’t hesitate to just adapt your fork and PR/merge that in upstream :)

@christophercr
Copy link
Collaborator

Closed in favor of this PR #445 which contains the final working solution.

@christophercr christophercr removed their request for review June 18, 2018 09:10
@dsebastien dsebastien deleted the feature/ghdeploy branch July 19, 2018 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

showcase & api docs: publish to github pages
4 participants