-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): added support for publishing api docs and showcase using Travis #416
Conversation
To actually test this, we'll need to create a release. |
EXPECTED_NODE_VERSION="8" | ||
|
||
COMMIT_AUTHOR_USERNAME="TravisCI" | ||
COMMIT_AUTHOR_EMAIL="seb@dsebastien.net" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not we create a specific email address (NBB) for Stark on GitHub ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but no :)
Actually, when we do a release, I think we should update the version to the next patch/minor one automatically 😊 |
57863d1
to
fe3b3b9
Compare
@christophercr, @RobbyDeLaet I leave this up to you guys :) Here's the alternative I had found: https://gist.github.com/douglasduteil/5525750 |
fe3b3b9
to
5d53f7a
Compare
This could be another alternative: https://gist.github.com/willprice/e07efd73fb7f13f917ea |
@dsebastien I tested again this and indeed the SSH key wasn't used when doing the git clone/push. So I used the other alternative you mentioned, and that works, this is the log of the successful build of my fork: https://travis-ci.org/christophercr/stark/jobs/393357177 I've adapted my fork so you can see the changes I did compared to what you have (but you need to rebase yours with the latest changes from the master): dsebastien/stark@feature/ghdeploy...christophercr:feature/ghdeploy |
Great! Don’t hesitate to just adapt your fork and PR/merge that in upstream :) |
Closed in favor of this PR #445 which contains the final working solution. |
Issues closed: #282
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We generate our docs but don't publish them
Issue Number: #282
What is the new behavior?
We publish the api docs and the showcase on GitHub pages.
Does this PR introduce a breaking change?
Other information
The solution is not complete yet, because other issues need to be tackled for this to be effective; for example #415