Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stark-core): fix support for URL query parameters #3811

Conversation

SuperITMan
Copy link
Member

ISSUE CLOSED: #3766

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3766

What is the new behavior?

Query params in URL are handled correctly.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@SuperITMan SuperITMan added type: bug comp: stark-core Stark Core 12.x Stark version labels Jun 4, 2024
@SuperITMan SuperITMan added this to the 12.0.0-beta.3 milestone Jun 4, 2024
@SuperITMan SuperITMan requested a review from mhenkens June 4, 2024 10:05
let hash: string | undefined;
const paramValues: RawParams = {};

// tslint:disable-next-line:no-self-assignment no-non-null-assertion no-dead-store
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are now using eslint. Please adapt the disable comment

@SuperITMan SuperITMan force-pushed the bugfix/fix-routing-service-3766 branch from c5ce08f to 5d07573 Compare June 4, 2024 12:32
@coveralls
Copy link

coveralls commented Jun 4, 2024

Coverage Status

coverage: 88.859% (+0.003%) from 88.856%
when pulling b2482b3 on SuperITMan:bugfix/fix-routing-service-3766
into a7cb51a on NationalBankBelgium:master.

@SuperITMan SuperITMan force-pushed the bugfix/fix-routing-service-3766 branch from 5d07573 to 74ae466 Compare June 5, 2024 07:18
@SuperITMan SuperITMan force-pushed the bugfix/fix-routing-service-3766 branch from 74ae466 to b2482b3 Compare June 5, 2024 07:21
Copy link

sonarqubecloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.0% Duplication on New Code

See analysis details on SonarCloud

@SuperITMan SuperITMan requested a review from mhenkens June 5, 2024 07:34
@SuperITMan SuperITMan merged commit 5dbc9a4 into NationalBankBelgium:master Jun 5, 2024
6 checks passed
@SuperITMan SuperITMan deleted the bugfix/fix-routing-service-3766 branch June 5, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: routing - cannot pass params to a URL
3 participants