Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stark-build) Remove config-stark files + Refactor tsconfig + Fix ts issues #244

Merged
merged 9 commits into from
Mar 12, 2018

Conversation

SuperITMan
Copy link
Member

@SuperITMan SuperITMan commented Mar 7, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[X] Feature
[X] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[X] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

TS issues in test because of Starter code

Issue Numbers: #63 #76 #130 #163

What is the new behavior?

Fixed multiple issues in the code. Followed NG Cli implementation for tsconfig files (stark-build, starter).
Now Starter contains 3 tsconfig files:

  • tsconfig.json --> IntelliJ
  • tsconfig.spec.json --> Webpack Test / Karma Test
  • tsconfig.app.json --> Webpack Build (Prod / Dev)

Removed part of config-stark files.

Added karma-typescript made by @christophercr

Does this PR introduce a breaking change?

[X] Yes
[ ] No

@SuperITMan
Copy link
Member Author

Commit updated

# Conflicts:
#	packages/stark-build/config-stark/webpack.dev.js
#	starter/tslint.json
@SuperITMan
Copy link
Member Author

Pull request synced with last changes

@ncedric ncedric merged commit d6683ba into NationalBankBelgium:master Mar 12, 2018
@SuperITMan SuperITMan modified the milestone: 10.0.0-alpha.1 Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants