Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/custom table actions #1376

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Fix/custom table actions #1376

merged 1 commit into from
Aug 7, 2019

Conversation

carlo-nomes
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1315

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@carlo-nomes carlo-nomes requested review from christophercr, SuperITMan and nicanac and removed request for christophercr August 2, 2019 13:16
@carlo-nomes carlo-nomes force-pushed the fix/custom-table-actions branch from df91529 to 30bacc5 Compare August 2, 2019 13:19
@carlo-nomes carlo-nomes force-pushed the fix/custom-table-actions branch from 30bacc5 to 0fdd43e Compare August 2, 2019 13:20
nicanac
nicanac reviewed Aug 2, 2019
View reviewed changes
Copy link
Contributor

@nicanac nicanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working flawlessly on my local

@coveralls
Copy link

coveralls commented Aug 2, 2019 •
edited
Loading

Coverage Status

Coverage increased (+2.5%) to 95.377% when pulling 0fdd43e on carlo-nomes:fix/custom-table-actions into feae581 on NationalBankBelgium:master.

@carlo-nomes carlo-nomes requested a review from nicanac August 2, 2019 13:44
@christophercr christophercr added this to the 10.0.0-rc.0 milestone Aug 3, 2019
christophercr
christophercr approved these changes Aug 3, 2019
View reviewed changes
Copy link
Collaborator

@christophercr christophercr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperITMan
Copy link
Member

LGTM 😊

@SuperITMan SuperITMan merged commit 2c8d661 into NationalBankBelgium:master Aug 7, 2019
@SuperITMan SuperITMan mentioned this pull request Jul 6, 2023
Closed
@SuperITMan SuperITMan mentioned this pull request Oct 5, 2023
Closed
@SuperITMan SuperITMan mentioned this pull request Feb 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperITMan SuperITMan SuperITMan approved these changes

@christophercr christophercr christophercr approved these changes

@nicanac nicanac Awaiting requested review from nicanac

Assignees
No one assigned
Labels
comp: stark-ui
Projects
None yet
Milestone
10.0.0-rc.0
Development

Successfully merging this pull request may close these issues.
5 participants
@carlo-nomes @coveralls @SuperITMan @christophercr @nicanac