Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): fix TypeScript compilation while linking stark-ui to showcase #1375

Closed

Conversation

carlo-nomes
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe: Development related issue

What is the current behavior?

TypeScript was not finding parts of the application while the stark-ui package was directly linked
to the showcase. (used for development)

What is the new behavior?

Stark-ui can be linked to showcase through the showcase/package.json and TypeScript will correctly compile both showcase and stark-ui.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

…case

TypeScript was not finding parts of the application while the stark-ui package was directly linked
to the showcase. (used for development)
Copy link
Member

@SuperITMan SuperITMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this PR does not really make sense... You should adapt your link in your project with the new implementation 😊

@@ -0,0 +1 @@
export * from "./public_api";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those files have been removed when we implemented ng-packagr.
You can the link in showcase as we do in stark-core or stark-ui :

"@nationalbankbelgium/stark-ui": ["../packages/stark-ui/public_api.ts"],
"@nationalbankbelgium/stark-ui/testing": ["../packages/stark-ui/testing/public_api.ts"],

Copy link
Collaborator Author

@carlo-nomes carlo-nomes Aug 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oke, that works. Thanks 👍
The environment doesn't give me an issue anymore either, but It should be relative right? 🤔

@@ -0,0 +1 @@
export * from "./public_api";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@carlo-nomes carlo-nomes closed this Aug 2, 2019
@carlo-nomes carlo-nomes deleted the fix/ts-bug branch August 2, 2019 13:41
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 92.909% when pulling 9bbeff3 on carlo-nomes:fix/ts-bug into feae581 on NationalBankBelgium:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants