Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stark-all): upgrade to TypeScript 3.2 (latest version supported in Angular 7.2) #1242

Merged

Conversation

christophercr
Copy link
Collaborator

@christophercr christophercr commented Apr 9, 2019

ISSUES CLOSED: #1234

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1234

What is the new behavior?

IMPORTANT
The new strictBindCallApply option in TS 3.2 is not added to packages/stark-build/tsconfig.json to avoid having a breaking change in all the apps whose tsconfig extend from this one so they are not forced to use TS 3.2. This is not an issue because the strict option is enabled so the new strictBindCallApply will be enalbled automatically in case the TypeScript version is 3.2 or higher. See https://github.com/Microsoft/TypeScript/wiki/What%27s-new-in-TypeScript#strictbindcallapply

Does this PR introduce a breaking change?

[ ] Yes
[X] No

@christophercr christophercr added this to the 10.0.0-beta.8 milestone Apr 9, 2019
@christophercr christophercr added comp: stark-all To apply for all Stark modules type: feature labels Apr 9, 2019
@coveralls
Copy link

coveralls commented Apr 9, 2019

Coverage Status

Coverage increased (+2.08%) to 94.819% when pulling 8d656e6 on christophercr:feature/typescript-3.2 into 8bae536 on NationalBankBelgium:master.

@christophercr christophercr force-pushed the feature/typescript-3.2 branch from 4d4ad97 to 600f88e Compare April 9, 2019 14:39
@christophercr christophercr requested a review from SuperITMan April 9, 2019 15:05
@SuperITMan SuperITMan merged commit 1100c62 into NationalBankBelgium:master Apr 9, 2019
@christophercr christophercr deleted the feature/typescript-3.2 branch April 25, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: stark-all To apply for all Stark modules type: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

all: typescript - upgrade Typescript to version 3.2
3 participants