Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/small css fixes #1225

Merged
merged 3 commits into from
Apr 1, 2019
Merged

Fix/small css fixes #1225

merged 3 commits into from
Apr 1, 2019

Conversation

carlo-nomes
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1181

What is the new behavior?

fixed

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@carlo-nomes carlo-nomes requested a review from SuperITMan March 28, 2019 14:49
@coveralls
Copy link

coveralls commented Mar 28, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.005%) to 94.69% when pulling 1d39083 on cnomes:fix/small-css-fixes into 517df61 on NationalBankBelgium:master.

@carlo-nomes carlo-nomes force-pushed the fix/small-css-fixes branch from 1578604 to ce31f28 Compare March 29, 2019 14:42
@SuperITMan SuperITMan added this to the 10.0.0-beta.7 milestone Mar 31, 2019
SuperITMan
SuperITMan requested changes Mar 31, 2019
View reviewed changes
Copy link
Member

@SuperITMan SuperITMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small change

packages/stark-ui/src/modules/route-search/components/_route-search-theme.scss Outdated
@@ -5,7 +5,7 @@
.search-field {
.mat-form-field-wrapper {
border: 1px solid mat-color($grey-palette, 400);
background-color: #ffff;
background-color: $offwhite;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please put back #fff ? 😊
Because the background-color of the auto-complete is white too. Otherwise, it's a bit weird according to me...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR. 😄

@carlo-nomes
fix(stark-ui): change background-color of `.search-field .mat-form-fi…
87aa706 
…eld-wrapper` to variable $offWh

  - `background-color: #ffff` was causing an issue in chrome 56
  - also removed duplicate code

ISSUES CLOSED: NationalBankBelgium#1181
@carlo-nomes
fix(stark-demo): fix reference border
3bd81e4
@carlo-nomes
fix(stark-demo): fix route-search-component tests failing with ` Un…
1d39083 
…caught TypeError: Cannot read property 'focus' of null thrown`
@carlo-nomes carlo-nomes force-pushed the fix/small-css-fixes branch from ce31f28 to 1d39083 Compare April 1, 2019 08:05
@SuperITMan SuperITMan merged commit 9b0a04c into NationalBankBelgium:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperITMan SuperITMan SuperITMan approved these changes

Assignees
No one assigned
Labels
comp: stark-ui type: bug
Projects
None yet
Milestone
10.0.0-beta.7
Development

Successfully merging this pull request may close these issues.
3 participants
@carlo-nomes @coveralls @SuperITMan