Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: table - limits #213

Closed
dsebastien opened this issue Mar 7, 2018 · 0 comments
Closed

ui: table - limits #213

dsebastien opened this issue Mar 7, 2018 · 0 comments
Labels
breaking change comp: stark-ui must type: enhancement
Milestone
must

Comments

@dsebastien
Copy link
Contributor

Limit table contents to n results in cached mode

  • flag to set the number of items to retrieve, maximum being 1000 by default
  • may retrieve more elements BUT only if a specific flag has been set (i.e., guard) -> awareOfPerformanceImpact

Idea: make it crystal clear that loading/displaying more than n elements is not a great idea for performance and usability reasons
@dsebastien dsebastien added this to the must milestone Mar 7, 2018
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Nov 8, 2018
@carlo-nomes
fix(stark-starter): add polyfill for String.prototype.trimRight
921bc9a 
IE11 required a polyfill for `String.prototype.trimRight`, this function was used by the `prettier`
dependency and caused an issue when using the `pretty-print` component.

ISSUES CLOSED: NationalBankBelgium#213
@carlo-nomes carlo-nomes mentioned this issue Nov 8, 2018
Merged
3 tasks
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Nov 8, 2018
@carlo-nomes
fix(stark-starter): add polyfill for String.prototype.trimRight
5230b8c 
IE11 required a polyfill for `String.prototype.trimRight`, this function was used by the `prettier`
dependency and caused an issue when using the `pretty-print` component.

ISSUES CLOSED: NationalBankBelgium#213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change comp: stark-ui must type: enhancement
Projects
None yet
Milestone
must
Development

No branches or pull requests
1 participant
@dsebastien