Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that the radiation pattern from a ring-current source with circular polarization has no azimuthal dependence #2978

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

oskooi
Copy link
Collaborator

@oskooi oskooi commented Feb 10, 2025

Adds a note to Tutorial/Radiation Pattern of a Disc in Cylindrical Coordinates to mention that the radiation pattern ($P(\theta)$ described in the text) from a ring-current source has no azimuthal dependence. This should help to clarify why the plot of the 3D radiation pattern has circular symmetry.

…a radiation pattern with no azimuthal dependence
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.79%. Comparing base (f29a8c7) to head (323eaec).
Report is 48 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2978      +/-   ##
==========================================
- Coverage   73.81%   73.79%   -0.03%     
==========================================
  Files          18       18              
  Lines        5423     5445      +22     
==========================================
+ Hits         4003     4018      +15     
- Misses       1420     1427       +7     

see 1 file with indirect coverage changes

@stevengj stevengj merged commit dbb56c6 into NanoComp:master Feb 13, 2025
5 checks passed
@oskooi oskooi deleted the radiation_pattern_cyl branch February 13, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants