Modify and update CMake #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
spdomin
commented
Sep 25, 2023
- as per New Nalu Trilinos config issues trilinos/Trilinos#12326
| @@ -13,6 +13,11 @@ option(ENABLE_PARAVIEW_CATALYST | |||
| option(ENABLE_WARNINGS "Add -Wall to show compiler warnings" ON) | |||
| option(ENABLE_EXTRA_WARNINGS "Add -Wextra to show even more compiler warnings" OFF) | |||
|
|
|||
| ########################### NALU-first ##################################### | |||
| # Set Nalu's compilers, CMAKE_FIND_LIBRARY_PREFIXES | |||
| # and CMAKE_FIND_LIBRARY_SUFFIXES, etc, after inheriting settings from Trilinos | |||
There was a problem hiding this comment.
"after inheriting settings from Trilinos" is not really true anymore, correct?
There was a problem hiding this comment.
You mean that second line?
There was a problem hiding this comment.
What I means is that NaLU is no longer "inheriting settings from Trilinos" since it has to define the compilers before calling find_package(Trilinos ...).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.