Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cookie session timestamp validation #387

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

loocars
Copy link
Collaborator

@loocars loocars commented Dec 19, 2024

In certain scenarios localhost could be blocked or take a long time to
resolve, hence the cookie session validation now uses the loopback
address directly instead of localhost

@LarsMichelsen
Copy link
Contributor

While this may help in certain scenarios, there are others which will break. There are IPv6 only systems out there which would not understand 127.0.0.1.

Ideas I have to solve it differently: We already use SERVER_PORT and may be able to use SERVER_HOST in addition.
Alternatively, we could also try to get the OMD config options (APACHE_TCP_ADDR, APACHE_TCP_PORT. They might be available as environment variable CONFIG_APACHE_TCP_PORT and CONFIG_APACHE_TCP_ADDR.

@loocars loocars force-pushed the sandbox/lukaslengler/master/fixloopback branch 2 times, most recently from d622457 to e668c07 Compare February 27, 2025 12:10
@loocars loocars force-pushed the sandbox/lukaslengler/master/fixloopback branch from e668c07 to 41e5eae Compare March 19, 2025 14:17
In certain scenarios localhost could be blocked or take a long time to
resolve, hence the cookie session validation now uses the loopback
address directly instead of localhost
@loocars loocars force-pushed the sandbox/lukaslengler/master/fixloopback branch from 41e5eae to 179de2a Compare March 20, 2025 07:32
@loocars loocars requested a review from LarsMichelsen March 21, 2025 07:58
@loocars loocars merged commit a7b3a26 into master Mar 21, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants