Show error message and hide test cases on judging failure

NZOI · Apr 28, 2024 · 9e7aa3e · 9e7aa3e
1 parent aac9a03
commit 9e7aa3e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/app/models/submission/judge_data.rb b/app/models/submission/judge_data.rb
@@ -274,7 +274,7 @@ def initialize(log, test_sets, test_cases, prerequisite_sets = [])
     end
 
     def errored?
-      data.has_key?('error')
+      data.has_key?('error') || status == :error
     end
 
     def completed?

diff --git a/app/views/submissions/show.html.erb b/app/views/submissions/show.html.erb
@@ -5,7 +5,12 @@
 
 <%= stylesheet_link_tag "submission" %>
 
-<% if @submission.score == nil %>
+<% @judge_data = @submission.judge_data %>
+<% if @judge_data.errored? %>
+  <p>
+    <b>An unexpected error has occurred during judging. Please retry the submission, or contact us at <%= mail_to "nzic@nzoi.org.nz" %> if the error persists.</b>
+  </p>
+<% elsif @submission.score == nil %>
   <p>
     <b>This submission has not finished judging. Refresh this page in a minute or two to see the submission's score.</b>
   </p>
@@ -46,7 +51,6 @@
   <% end %>
 </p>
 
-<% @judge_data = @submission.judge_data %>
 <% if @judge_data.compiled? %>
   <table class="results">
     <tbody class="compilation status_<%= @judge_data.compilation.status %>">
@@ -76,7 +80,7 @@
   </table>
 <% end %>
 <table class="results">
-  <% if !@judge_data.compiled? || @judge_data.compilation.status == :success %>
+  <% if !@judge_data.errored? && (!@judge_data.compiled? || @judge_data.compilation.status == :success) %>
     <tbody class="headings">
       <th class="test_name"></th>
       <th>Time</th>