Jest 19 #422
Merged
Jest 19 #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When testing the starter-kyts, this message from Jest shows up (for both starter-kyts): Not entirely sure why 🤔 The tests pass though |
tizmagik
commented
Feb 27, 2017
packages/kyt-core/package.json
Outdated
| "react": "^15.4.2", | ||
| "react-addons-test-utils": "^15.4.2", | ||
| "react-dom": "^15.4.2" | ||
| } |
There was a problem hiding this comment.
Had to add these because of enzyme-to-json serializer. It's a devDependency so it shouldn't affect anything in the published packages.
* master: Upgrade stylelint (#417) Update to Webpack 2.2 (#396) Version and install starter-kyts with npm (#425) adds prep for 0.4.1 (#428) fixes static public path for noServer configuration (#427) Adds local-path argument for testing local starter-kyt setup (#403) # Conflicts: # packages/kyt-core/package.json # packages/kyt-core/yarn.lock # packages/kyt-starter-static/starter-src/yarn.lock # packages/kyt-starter-universal/starter-src/src/yarn.lock # yarn.lock
ccpricenytimes
suggested changes
Mar 10, 2017
There was a problem hiding this comment.
Hey @tizmagik this looks good. Can you add a note about the changes in CHANGELOG.md ?
Also are there any breaking changes users will need to know about? If so we should start a docs branch for 0.5.0 and make updates.
ccpricenytimes
approved these changes
Mar 10, 2017
delambo
approved these changes
Mar 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #394