Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Fix tuple_size/tuple_element for cv-qualified types #1457

Merged
merged 8 commits into from
Jul 8, 2021
Merged

Fix tuple_size/tuple_element for cv-qualified types #1457

merged 8 commits into from
Jul 8, 2021

Conversation

jrhemstad
Copy link
Collaborator

fixes #1456

@alliepiper alliepiper self-assigned this Jun 9, 2021
@alliepiper alliepiper added this to the 1.13.0 milestone Jun 9, 2021
@alliepiper
Copy link
Collaborator

run tests

@alliepiper
Copy link
Collaborator

DVS CL: 30066487

@alliepiper alliepiper added testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). testing: gpuCI in progress Started gpuCI testing. labels Jun 11, 2021
@alliepiper
Copy link
Collaborator

@jrhemstad This is failing gpuCI tests. Can you take a look?

I'm planning to cut 1.13's first RC today/tomorrow. Do you need this in 1.13 or can it wait for 1.14?

@alliepiper alliepiper removed testing: gpuCI in progress Started gpuCI testing. testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). labels Jun 14, 2021
@alliepiper alliepiper assigned jrhemstad and unassigned alliepiper Jun 14, 2021
@jrhemstad
Copy link
Collaborator Author

Yeah, there's a flaw with my solution. I'm working on a better one now.

It doesn't matter to me which release this gets into.

@alliepiper
Copy link
Collaborator

Sounds good. I'll move this to 1.14 so no rush.

@alliepiper alliepiper modified the milestones: 1.13.0, 1.14.0 Jun 14, 2021
@jrhemstad
Copy link
Collaborator Author

run tests

@jrhemstad jrhemstad changed the title Change tuple_size/tuple_element pair specializations to use const Fix tuple_size/tuple_element for cv-qualified types Jun 24, 2021
@jrhemstad
Copy link
Collaborator Author

@allisonvacanti is the failure for nvc++ expected?

@alliepiper
Copy link
Collaborator

Yeah, we're in the process of updating that builder to a new nvhpc version. You can ignore it for now.

@jrhemstad
Copy link
Collaborator Author

@allisonvacanti this should be good to test on DVS now.

@alliepiper
Copy link
Collaborator

DVS CL: 30144504

@alliepiper alliepiper added testing: gpuCI passed Passed gpuCI testing. testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). labels Jul 1, 2021
@alliepiper alliepiper added testing: internal ci passed Passed internal NVIDIA CI (DVS). and removed testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). labels Jul 8, 2021
@alliepiper alliepiper merged commit bd63dd1 into NVIDIA:main Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alliepiper alliepiper alliepiper approved these changes

Assignees

@jrhemstad jrhemstad

Labels
testing: gpuCI passed Passed gpuCI testing. testing: internal ci passed Passed internal NVIDIA CI (DVS).
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

thrust::tuple_size fails for "const thrust::pair<T1,T2>"
2 participants
@jrhemstad @alliepiper