This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Qualify calls to make_reverse_iterator #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unqualified calls to make_reverse_iterator would result in ADL ambiguities between std::make_reverse_iterator and thrust::make_reverse_iterator when the iterator argument is a std::vector<T>::iterator or other "std" type. Fix the problem and avoid ADL by changing the call to the qualified name thrust::make_reverse_iterator.
|
Can one of the admins verify this patch? |
|
LGTM, DVS CL 29385928 |
alliepiper
approved these changes
Dec 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unqualified calls to
make_reverse_iteratorwould result in ADL ambiguities betweenstd::make_reverse_iteratorandthrust::make_reverse_iteratorwhen compiling in C++14 mode and the iterator argument is astd::vector<T>::iteratoror otherstdtype. Fix the problem and avoid ADL by changing the call to the qualified namethrust::make_reverse_iterator.This was discovered in a parallel algorithms test suite for NVC++, when we recently changed the test suite to sometimes compile in C++14 mode.
std::make_reverse_iteratoris new to C++14, so the bug doesn't happen when building in C++11 mode.