Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Use transparent functors in placeholder expressions. #1237

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Use transparent functors in placeholder expressions. #1237

merged 1 commit into from
Aug 28, 2020

Conversation

alliepiper
Copy link
Collaborator

Fixes and adds regression tests for #1178 & #1229.

@alliepiper alliepiper added this to the 1.10.0 milestone Jul 17, 2020
@alliepiper alliepiper force-pushed the bug/transparent_placeholder_functionals/gh.1178/gh.1229 branch 3 times, most recently from 1de9eb0 to 38c9475 Compare July 17, 2020 16:15
@mfrancis95
Copy link
Contributor

Is the plan to bring #1186 back after this is merged in?

@alliepiper
Copy link
Collaborator Author

That commit was only reverted on a staging branch for an upcoming release, which is only taking critical bugfixes right now.

#1186 is still in main and this patch fixes the related regressions by making the placeholder implementation more robust.

@alliepiper alliepiper force-pushed the bug/transparent_placeholder_functionals/gh.1178/gh.1229 branch from 38c9475 to a4bf7f7 Compare July 24, 2020 17:40
@alliepiper alliepiper added the testing: gpuCI passed Passed gpuCI testing. label Jul 25, 2020
@alliepiper alliepiper force-pushed the bug/transparent_placeholder_functionals/gh.1178/gh.1229 branch from a4bf7f7 to ef1ad8a Compare July 27, 2020 20:35
@alliepiper
Copy link
Collaborator Author

Rebased on master, started DVS CL 28862936.

@alliepiper alliepiper added the testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). label Jul 27, 2020
@alliepiper alliepiper force-pushed the bug/transparent_placeholder_functionals/gh.1178/gh.1229 branch 2 times, most recently from dd12cba to ade1934 Compare August 3, 2020 19:30
@alliepiper
Copy link
Collaborator Author

Confirmed that this change doesn't significantly impact compile times.

Restarted DVS on same CL after refactoring the new static assert in actor.

@alliepiper alliepiper force-pushed the bug/transparent_placeholder_functionals/gh.1178/gh.1229 branch from ade1934 to a2451e3 Compare August 7, 2020 21:11
@alliepiper alliepiper added testing: internal ci passed Passed internal NVIDIA CI (DVS). and removed testing: gpuCI passed Passed gpuCI testing. testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). labels Aug 27, 2020
@alliepiper
Copy link
Collaborator Author

@dkolsen-pgi can you review this when you get a chance? It addresses your issue with thrust::find, #1229.

@alliepiper alliepiper force-pushed the bug/transparent_placeholder_functionals/gh.1178/gh.1229 branch from a2451e3 to aa6dc83 Compare August 28, 2020 20:15
@alliepiper
Copy link
Collaborator Author

rebased and addressed review feedback.

@alliepiper alliepiper merged commit 52a8bda into NVIDIA:main Aug 28, 2020
@alliepiper alliepiper deleted the bug/transparent_placeholder_functionals/gh.1178/gh.1229 branch August 28, 2020 20:17
This was referenced Aug 28, 2020
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dkolsen-pgi dkolsen-pgi dkolsen-pgi approved these changes

Assignees
No one assigned
Labels
testing: internal ci passed Passed internal NVIDIA CI (DVS).
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alliepiper @mfrancis95 @dkolsen-pgi