Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade iceberg support to 1.6.1 #12208

Open
wants to merge 8 commits into
base: branch-25.04
Choose a base branch
from

Conversation

liurenjie1024
Copy link
Collaborator

@liurenjie1024 liurenjie1024 commented Feb 24, 2025

Closes #12193 .

Upgrade iceberg version to 1.6.1, also skip iceberg tests for now.

@liurenjie1024 liurenjie1024 requested a review from a team as a code owner February 24, 2025 07:39
Signed-off-by: liurenjie1024 <liurenjie2008@gmail.com>

Signed-off-by: liurenjie1024 <liurenjie2008@gmail.com>
Signed-off-by: liurenjie1024 <liurenjie2008@gmail.com>
@liurenjie1024
Copy link
Collaborator Author

build

Signed-off-by: liurenjie1024 <liurenjie2008@gmail.com>
@liurenjie1024
Copy link
Collaborator Author

build

@liurenjie1024
Copy link
Collaborator Author

liurenjie1024 commented Feb 24, 2025

cc @gerashegalov Should we disable iceberg integration test first? I tried to run locally and it failed, and it seems not trivial to fix them.

@liurenjie1024
Copy link
Collaborator Author

We can add them back one by one when we resolve issues in #12176

Signed-off-by: liurenjie1024 <liurenjie2008@gmail.com>
Signed-off-by: liurenjie1024 <liurenjie2008@gmail.com>
Signed-off-by: liurenjie1024 <liurenjie2008@gmail.com>
@liurenjie1024
Copy link
Collaborator Author

build

@sameerz
Copy link
Collaborator

sameerz commented Feb 25, 2025

cc @gerashegalov Should we disable iceberg integration test first? I tried to run locally and it failed, and it seems not trivial to fix them.

@liurenjie1024 we should not skip the tests if there are known failures that users will be exposed to.

@sameerz sameerz added the feature request New feature or request label Feb 25, 2025
@liurenjie1024
Copy link
Collaborator Author

liurenjie1024 commented Feb 26, 2025

cc @gerashegalov Should we disable iceberg integration test first? I tried to run locally and it failed, and it seems not trivial to fix them.

@liurenjie1024 we should not skip the tests if there are known failures that users will be exposed to.

Hi, @sameerz Do you mean we should add xfail to know failures?

@liurenjie1024
Copy link
Collaborator Author

cc @gerashegalov Should we disable iceberg integration test first? I tried to run locally and it failed, and it seems not trivial to fix them.

@liurenjie1024 we should not skip the tests if there are known failures that users will be exposed to.

Hi, @sameerz I've checked the error and the failure reason is that iceberg 1.6.1 no longer support directly creating data source using iceberg, it requires setting up a catalog to do that. If we want to fix it, we need to change all tests, which seems unnecessary effort since we will add them back gradually when we implement features. WDYT?

@gerashegalov
Copy link
Collaborator

We can xfail tests if we create an epic to fix it and reference them in our test

if we fix/add a fixture to create proper tables via SQL or catalog api, do we expect most tests to pass with the current code ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup support for recently released iceberg.
3 participants