Fix string_test.py errors on Spark 4.0
#11247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NVIDIA#11030. This commit skips the tests pertaining to the following operations on Apache Spark 4.0: 1. Column.endswith() 2. substring_index() In both cases, the CPU version of Apache Spark 4.0 seems to cause exceptions, unrelated to the Spark RAPIDS plugin. See: 1. https://issues.apache.org/jira/browse/SPARK-48989 2. https://issues.apache.org/jira/browse/SPARK-48995 Signed-off-by: MithunR <mithunr@nvidia.com>
|
Pinging @razajafri for a review. The Apache Spark JIRAs associated with the skipped tests are listed in the description. |
|
I was able to repro 2. pretty consistently. |
razajafri
approved these changes
Jul 25, 2024
|
build |
mythrocks
added a commit
to mythrocks/spark-rapids
that referenced
this pull request
Oct 28, 2024
Fixes NVIDIA#11535. This commit fixes the failure of `test_startswith` and `test_endswith` in `string_test.py` on Databricks 14.3. This is, in effect, a follow-on to the changes introduced in NVIDIA#11247, where `test_endswith` was skipped for Databricks 4.0, on account of https://issues.apache.org/jira/browse/SPARK-48995. It appears that that bug afflicts Databricks 14.3 as well. This commit handles both `test_startswith` and `test_endswith` for Databricks 14.3 and Apache Spark 4.0. Signed-off-by: MithunR <mithunr@nvidia.com>
mythrocks
added a commit
that referenced
this pull request
Nov 6, 2024
* Fix string_test for [databricks] 14.3 Fixes #11535. This commit fixes the failure of `test_startswith` and `test_endswith` in `string_test.py` on Databricks 14.3. This is, in effect, a follow-on to the changes introduced in #11247, where `test_endswith` was skipped for Databricks 4.0, on account of https://issues.apache.org/jira/browse/SPARK-48995. It appears that that bug afflicts Databricks 14.3 as well. This commit handles both `test_startswith` and `test_endswith` for Databricks 14.3 and Apache Spark 4.0. Signed-off-by: MithunR <mithunr@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11030.
This commit skips the tests pertaining to the following operations on Apache Spark 4.0:
In both cases, the CPU version of Apache Spark 4.0 seems to cause exceptions, unrelated to the Spark RAPIDS plugin. See: