Fix a hive write test failure #10958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
build |
|
Minor note, does this also close #9939 ? |
thirtiseven
approved these changes
Jun 5, 2024
firestarman
added a commit
that referenced
this pull request
Jun 11, 2024
This is a bug fix for the hive write tests. This is simliar as #10958 but it fixes the failures for Spark 350. The tests fail because the ProjectExec will fall back to CPU due to missing the GPU version of the MapFromArrays expression. This PR adds the ProjectExec to the allowed list of fallback for Spark 350 and the laters. Signed-off-by: Firestarman <firestarmanllc@gmail.com>
SurajAralihalli
pushed a commit
to SurajAralihalli/spark-rapids
that referenced
this pull request
Jul 12, 2024
This is a bug fix for the hive write tests. In some of the tests on Spak 351, the ProjectExec will fall back to CPU due to missing the GPU version of the MapFromArrays expression. This PR adds the ProjectExec to the allowed list of fallback for Spark 351 and the laters. Signed-off-by: Firestarman <firestarmanllc@gmail.com>
SurajAralihalli
pushed a commit
to SurajAralihalli/spark-rapids
that referenced
this pull request
Jul 12, 2024
This is a bug fix for the hive write tests. This is simliar as NVIDIA#10958 but it fixes the failures for Spark 350. The tests fail because the ProjectExec will fall back to CPU due to missing the GPU version of the MapFromArrays expression. This PR adds the ProjectExec to the allowed list of fallback for Spark 350 and the laters. Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10956
This is a bug fix for the hive write tests. In some of the tests on Spak 351, the
ProjectExecwill fall back to CPU due to missing the GPU version of theMapFromArraysexpression.This PR adds the
ProjectExecto the allowed list of fallback for Spark 351 and the laters.