Add classloader diagnostics to initShuffleManager error message #10871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlowe
reviewed
May 23, 2024
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
…into 10172_log_shuffle_manager_class
Signed-off-by: Zach Puller <zpuller@nvidia.com>
Signed-off-by: Zach Puller <zpuller@nvidia.com>
Signed-off-by: Zach Puller <zpuller@nvidia.com>
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuShuffleEnv.scala
Outdated
Show resolved
Hide resolved
…leEnv.scala Co-authored-by: Gera Shegalov <gshegalov@nvidia.com>
gerashegalov
previously approved these changes
May 25, 2024
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuShuffleEnv.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuShuffleEnv.scala
Outdated
Show resolved
Hide resolved
…leEnv.scala Co-authored-by: Gera Shegalov <gshegalov@nvidia.com>
…leEnv.scala Co-authored-by: Gera Shegalov <gshegalov@nvidia.com>
|
build |
jlowe
reviewed
May 28, 2024
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuShuffleEnv.scala
Show resolved
Hide resolved
|
@zpuller curious why this is in draft? I didn't find any explanation text. |
You're right, it's really no longer a draft. Fixed the title/description. |
|
build |
abellina
reviewed
May 28, 2024
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuShuffleEnv.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuShuffleEnv.scala
Show resolved
Hide resolved
…leEnv.scala Co-authored-by: Alessandro Bellina <abellina@gmail.com>
|
build |
abellina
previously approved these changes
May 28, 2024
Signed-off-by: Zach Puller <zpuller@nvidia.com>
jlowe
approved these changes
May 28, 2024
|
build |
SurajAralihalli
pushed a commit
to SurajAralihalli/spark-rapids
that referenced
this pull request
Jul 12, 2024
…IA#10871) Add classloader diagnostics to initShuffleManager error message --------- Signed-off-by: Zach Puller <zpuller@nvidia.com> Co-authored-by: Jason Lowe <jlowe@nvidia.com> Co-authored-by: Gera Shegalov <gshegalov@nvidia.com> Co-authored-by: Alessandro Bellina <abellina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10172
As mentioned in the above issue, presumably this error is hit when the classloaders are different for the RapidsShuffleManagerLike interface in the
caseclause vs the implementation version, so we are adding logging of these classloader instance values for troubleshooting purposes.