Skip to content

Commit

Permalink
one line doc
Browse files Browse the repository at this point in the history
Signed-off-by: Gera Shegalov <gera@apache.org>
  • Loading branch information
gerashegalov committed Aug 23, 2023
1 parent aa3777f commit dffc30f
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 56 deletions.
9 changes: 1 addition & 8 deletions docs/additional-functionality/advanced_configs.md
Original file line number Diff line number Diff line change
Expand Up @@ -208,14 +208,7 @@ Name | SQL Function(s) | Description | Default Value | Notes
<a name="sql.expression.Concat"></a>spark.rapids.sql.expression.Concat|`concat`|List/String concatenate|true|None|
<a name="sql.expression.ConcatWs"></a>spark.rapids.sql.expression.ConcatWs|`concat_ws`|Concatenates multiple input strings or array of strings into a single string using a given separator|true|None|
<a name="sql.expression.Contains"></a>spark.rapids.sql.expression.Contains| |Contains|true|None|
<a name="sql.expression.Conv"></a>spark.rapids.sql.expression.Conv|`conv`|Convert string representing a number from one base to another|false|This is disabled by default because GPU implementation is incomplete. We currently only support from/to_base 10 and 16. We
fall back on CPU if the signed conversion is signalled via a negative to_base.
GPU implementation does not check for 64-bit int overflow when performing the conversion
to return FFFFFFFFFFFFFFFF or 18446744073709551615 or to throw an error in the ANSI mode.
It is safe to enable if the overflow is not possible or detected externally.
For instance decimal strings not longer than 18 characters / hexadecimal strings
not longer than 15 characters disregarding the sign cannot cause an overflow.
|
<a name="sql.expression.Conv"></a>spark.rapids.sql.expression.Conv|`conv`|Convert string representing a number from one base to another|false|This is disabled by default because GPU implementation is incomplete. We currently only support from/to_base values of 10 and 16. We fall back on CPU if the signed conversion is signalled via a negative to_base. GPU implementation does not check for an 64-bit signed/unsigned int overflow when performing the conversion to return `FFFFFFFFFFFFFFFF` or `18446744073709551615` or to throw an error in the ANSI mode. It is safe to enable if the overflow is not possible or detected externally. For instance decimal strings not longer than 18 characters / hexadecimal strings not longer than 15 characters disregarding the sign cannot cause an overflow. |
<a name="sql.expression.Cos"></a>spark.rapids.sql.expression.Cos|`cos`|Cosine|true|None|
<a name="sql.expression.Cosh"></a>spark.rapids.sql.expression.Cosh|`cosh`|Hyperbolic cosine|true|None|
<a name="sql.expression.Cot"></a>spark.rapids.sql.expression.Cot|`cot`|Cotangent|true|None|
Expand Down
9 changes: 1 addition & 8 deletions docs/supported_ops.md
Original file line number Diff line number Diff line change
Expand Up @@ -4513,14 +4513,7 @@ are limited.
<td rowSpan="4">Conv</td>
<td rowSpan="4">`conv`</td>
<td rowSpan="4">Convert string representing a number from one base to another</td>
<td rowSpan="4">This is disabled by default because GPU implementation is incomplete. We currently only support from/to_base 10 and 16. We
fall back on CPU if the signed conversion is signalled via a negative to_base.
GPU implementation does not check for 64-bit int overflow when performing the conversion
to return FFFFFFFFFFFFFFFF or 18446744073709551615 or to throw an error in the ANSI mode.
It is safe to enable if the overflow is not possible or detected externally.
For instance decimal strings not longer than 18 characters / hexadecimal strings
not longer than 15 characters disregarding the sign cannot cause an overflow.
</td>
<td rowSpan="4">This is disabled by default because GPU implementation is incomplete. We currently only support from/to_base values of 10 and 16. We fall back on CPU if the signed conversion is signalled via a negative to_base. GPU implementation does not check for an 64-bit signed/unsigned int overflow when performing the conversion to return `FFFFFFFFFFFFFFFF` or `18446744073709551615` or to throw an error in the ANSI mode. It is safe to enable if the overflow is not possible or detected externally. For instance decimal strings not longer than 18 characters / hexadecimal strings not longer than 15 characters disregarding the sign cannot cause an overflow. </td>
<td rowSpan="4">project</td>
<td>num</td>
<td> </td>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3054,14 +3054,16 @@ object GpuOverrides extends Logging {
(convExpr, conf, parentMetaOpt, dataFromReplacementRule) =>
new GpuConvMeta(convExpr, conf, parentMetaOpt, dataFromReplacementRule)
).disabledByDefault(
"""|GPU implementation is incomplete. We currently only support from/to_base 10 and 16. We
| fall back on CPU if the signed conversion is signalled via a negative to_base.
| GPU implementation does not check for 64-bit int overflow when performing the conversion
| to return FFFFFFFFFFFFFFFF or 18446744073709551615 or to throw an error in the ANSI mode.
| It is safe to enable if the overflow is not possible or detected externally.
| For instance decimal strings not longer than 18 characters / hexadecimal strings
| not longer than 15 characters disregarding the sign cannot cause an overflow.
""".stripMargin),
"""GPU implementation is incomplete. We currently only support from/to_base values
|of 10 and 16. We fall back on CPU if the signed conversion is signalled via
|a negative to_base.
|GPU implementation does not check for an 64-bit signed/unsigned int overflow when
|performing the conversion to return `FFFFFFFFFFFFFFFF` or `18446744073709551615` or
|to throw an error in the ANSI mode.
|It is safe to enable if the overflow is not possible or detected externally.
|For instance decimal strings not longer than 18 characters / hexadecimal strings
|not longer than 15 characters disregarding the sign cannot cause an overflow.
""".stripMargin.replaceAll("\n", " ")),
expr[MapConcat](
"Returns the union of all the given maps",
ExprChecks.projectOnly(TypeSig.MAP.nested(TypeSig.commonCudfTypes + TypeSig.DECIMAL_128 +
Expand Down
36 changes: 4 additions & 32 deletions tools/generated_files/supportedExprs.csv
Original file line number Diff line number Diff line change
Expand Up @@ -127,38 +127,10 @@ ConcatWs,S,`concat_ws`,None,project,result,NA,NA,NA,NA,NA,NA,NA,NA,NA,S,NA,NA,NA
Contains,S, ,None,project,src,NA,NA,NA,NA,NA,NA,NA,NA,NA,S,NA,NA,NA,NA,NA,NA,NA,NA
Contains,S, ,None,project,search,NA,NA,NA,NA,NA,NA,NA,NA,NA,PS,NA,NA,NA,NA,NA,NA,NA,NA
Contains,S, ,None,project,result,S,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA
Conv,NS,`conv`,This is disabled by default because GPU implementation is incomplete. We currently only support from/to_base 10 and 16. We
fall back on CPU if the signed conversion is signalled via a negative to_base.
GPU implementation does not check for 64-bit int overflow when performing the conversion
to return FFFFFFFFFFFFFFFF or 18446744073709551615 or to throw an error in the ANSI mode.
It is safe to enable if the overflow is not possible or detected externally.
For instance decimal strings not longer than 18 characters / hexadecimal strings
not longer than 15 characters disregarding the sign cannot cause an overflow.
,project,num,NA,NA,NA,NA,NA,NA,NA,NA,NA,S,NA,NA,NA,NA,NA,NA,NA,NA
Conv,NS,`conv`,This is disabled by default because GPU implementation is incomplete. We currently only support from/to_base 10 and 16. We
fall back on CPU if the signed conversion is signalled via a negative to_base.
GPU implementation does not check for 64-bit int overflow when performing the conversion
to return FFFFFFFFFFFFFFFF or 18446744073709551615 or to throw an error in the ANSI mode.
It is safe to enable if the overflow is not possible or detected externally.
For instance decimal strings not longer than 18 characters / hexadecimal strings
not longer than 15 characters disregarding the sign cannot cause an overflow.
,project,from_base,NA,PS,PS,PS,PS,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA
Conv,NS,`conv`,This is disabled by default because GPU implementation is incomplete. We currently only support from/to_base 10 and 16. We
fall back on CPU if the signed conversion is signalled via a negative to_base.
GPU implementation does not check for 64-bit int overflow when performing the conversion
to return FFFFFFFFFFFFFFFF or 18446744073709551615 or to throw an error in the ANSI mode.
It is safe to enable if the overflow is not possible or detected externally.
For instance decimal strings not longer than 18 characters / hexadecimal strings
not longer than 15 characters disregarding the sign cannot cause an overflow.
,project,to_base,NA,PS,PS,PS,PS,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA
Conv,NS,`conv`,This is disabled by default because GPU implementation is incomplete. We currently only support from/to_base 10 and 16. We
fall back on CPU if the signed conversion is signalled via a negative to_base.
GPU implementation does not check for 64-bit int overflow when performing the conversion
to return FFFFFFFFFFFFFFFF or 18446744073709551615 or to throw an error in the ANSI mode.
It is safe to enable if the overflow is not possible or detected externally.
For instance decimal strings not longer than 18 characters / hexadecimal strings
not longer than 15 characters disregarding the sign cannot cause an overflow.
,project,result,NA,NA,NA,NA,NA,NA,NA,NA,NA,S,NA,NA,NA,NA,NA,NA,NA,NA
Conv,NS,`conv`,This is disabled by default because GPU implementation is incomplete. We currently only support from/to_base values of 10 and 16. We fall back on CPU if the signed conversion is signalled via a negative to_base. GPU implementation does not check for an 64-bit signed/unsigned int overflow when performing the conversion to return `FFFFFFFFFFFFFFFF` or `18446744073709551615` or to throw an error in the ANSI mode. It is safe to enable if the overflow is not possible or detected externally. For instance decimal strings not longer than 18 characters / hexadecimal strings not longer than 15 characters disregarding the sign cannot cause an overflow. ,project,num,NA,NA,NA,NA,NA,NA,NA,NA,NA,S,NA,NA,NA,NA,NA,NA,NA,NA
Conv,NS,`conv`,This is disabled by default because GPU implementation is incomplete. We currently only support from/to_base values of 10 and 16. We fall back on CPU if the signed conversion is signalled via a negative to_base. GPU implementation does not check for an 64-bit signed/unsigned int overflow when performing the conversion to return `FFFFFFFFFFFFFFFF` or `18446744073709551615` or to throw an error in the ANSI mode. It is safe to enable if the overflow is not possible or detected externally. For instance decimal strings not longer than 18 characters / hexadecimal strings not longer than 15 characters disregarding the sign cannot cause an overflow. ,project,from_base,NA,PS,PS,PS,PS,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA
Conv,NS,`conv`,This is disabled by default because GPU implementation is incomplete. We currently only support from/to_base values of 10 and 16. We fall back on CPU if the signed conversion is signalled via a negative to_base. GPU implementation does not check for an 64-bit signed/unsigned int overflow when performing the conversion to return `FFFFFFFFFFFFFFFF` or `18446744073709551615` or to throw an error in the ANSI mode. It is safe to enable if the overflow is not possible or detected externally. For instance decimal strings not longer than 18 characters / hexadecimal strings not longer than 15 characters disregarding the sign cannot cause an overflow. ,project,to_base,NA,PS,PS,PS,PS,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA
Conv,NS,`conv`,This is disabled by default because GPU implementation is incomplete. We currently only support from/to_base values of 10 and 16. We fall back on CPU if the signed conversion is signalled via a negative to_base. GPU implementation does not check for an 64-bit signed/unsigned int overflow when performing the conversion to return `FFFFFFFFFFFFFFFF` or `18446744073709551615` or to throw an error in the ANSI mode. It is safe to enable if the overflow is not possible or detected externally. For instance decimal strings not longer than 18 characters / hexadecimal strings not longer than 15 characters disregarding the sign cannot cause an overflow. ,project,result,NA,NA,NA,NA,NA,NA,NA,NA,NA,S,NA,NA,NA,NA,NA,NA,NA,NA
Cos,S,`cos`,None,project,input,NA,NA,NA,NA,NA,NA,S,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA
Cos,S,`cos`,None,project,result,NA,NA,NA,NA,NA,NA,S,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA
Cos,S,`cos`,None,AST,input,NA,NA,NA,NA,NA,NA,S,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA
Expand Down

0 comments on commit dffc30f

Please sign in to comment.