[BUG] Remove duplicated executor CPU time and runtime metric from SQLTaskAggMetricsProfileResult #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cindyyuanjiang <cindyj@nvidia.com>
Signed-off-by: cindyyuanjiang <cindyj@nvidia.com>
amahussein
requested changes
Jan 21, 2025
There was a problem hiding this comment.
Thanks @cindyyuanjiang
SQLTaskAggMetricsProfileResult had 2 duplicate fields:
- executorRunTime and executorRunTimeSum
- executorCPUTime and executorCPUTimeSum
Can you please add more details to the PR description to list the CSV files affected by the change and the names of the columns that are going to be removed in each file.
This will make it easy for us to enumerate the changes associated with the affect_output tag.
core/src/main/scala/com/nvidia/spark/rapids/tool/analysis/AppSparkMetricsAnalyzer.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/nvidia/spark/rapids/tool/profiling/ProfileClassWarehouse.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: cindyyuanjiang <cindyj@nvidia.com>
parthosa
approved these changes
Jan 21, 2025
amahussein
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1467.
SQLTaskAggMetricsProfileResulthas 2 duplicate fields:executorRunTimeandexecutorRunTimeSumexecutorCPUTimeandexecutorCPUTimeSumChanges
SQLTaskAggMetricsProfileResultAffected Output
sql_level_aggregated_task_metrics.csvRemoved columns:
executorCPUTime,executorRunTime