Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] RunningWindowFunction should be marked as supported by QualificationTool #1460

Closed
amahussein opened this issue Dec 12, 2024 · 0 comments · Fixed by #1465
Closed

[BUG] RunningWindowFunction should be marked as supported by QualificationTool #1460

amahussein opened this issue Dec 12, 2024 · 0 comments · Fixed by #1465
Assignees
@amahussein
Labels
bug Something isn't working core_tools Scope the core module (scala)

Comments

@amahussein
Copy link
Collaborator

amahussein commented Dec 12, 2024 •
edited
Loading

Describe the bug

RunningWindowFunction does not appear in the plugin's CSV file. Although we have shims implemented https://github.com/NVIDIA/spark-rapids/blob/38d66b0c58fa8c8296c216a5626a3233877a67fe/sql-plugin/src/main/spark330db/scala/com/nvidia/spark/rapids/shims/GpuRunningWindowExecMeta.scala#L34

The exec name should be appended to the supported_execs.csv file and see if we need to parse the node content to decide if it is supported or not.

CC: @kuhushukla and @viadea
@amahussein amahussein added ? - Needs Triage bug Something isn't working core_tools Scope the core module (scala) and removed ? - Needs Triage labels Dec 12, 2024
@amahussein amahussein self-assigned this Dec 13, 2024
amahussein added a commit to amahussein/spark-rapids-tools that referenced this issue Dec 13, 2024
@amahussein
Mark RunningWindowFunction as supported in Qual tool
ecdb3cc 
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>

Fix NVIDIA#1460

`RunningWindowFunction` should be marked as supported by the
qualification tool.
@amahussein amahussein mentioned this issue Dec 13, 2024
Merged
amahussein added a commit that referenced this issue Dec 16, 2024
@amahussein
Mark RunningWindowFunction as supported in Qual tool (#1465)
9564d0b 
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>

Fix #1460

`RunningWindowFunction` should be marked as supported by the
qualification tool.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amahussein amahussein

Labels
bug Something isn't working core_tools Scope the core module (scala)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark RunningWindowFunction as supported in Qual tool amahussein/spark-rapids-tools
1 participant
@amahussein