This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 448
P2322R6 accumulator types for scan and reduce by key #511
Merged
gevtushenko
merged 7 commits into
NVIDIA:main
from
gevtushenko:fix-main/github/scan_intermediate_type
Aug 3, 2022
Merged
P2322R6 accumulator types for scan and reduce by key #511
gevtushenko
merged 7 commits into
NVIDIA:main
from
gevtushenko:fix-main/github/scan_intermediate_type
Aug 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gevtushenko
force-pushed
the
fix-main/github/scan_intermediate_type
branch
3 times, most recently
from
June 17, 2022 17:19
e8e7ec8
to
1ca4561
Compare
alliepiper
added
type: enhancement
New feature or request.
P1: should have
Necessary, but not critical.
release: breaking change
Include in "Breaking Changes" section of release notes.
labels
Jun 22, 2022
alliepiper
approved these changes
Jul 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments inline. This will also need a breaking changes summary (APIs, behaviors) in the description.
gevtushenko
force-pushed
the
fix-main/github/scan_intermediate_type
branch
from
August 2, 2022 12:32
1ca4561
to
b200436
Compare
gevtushenko
force-pushed
the
fix-main/github/scan_intermediate_type
branch
from
August 3, 2022 15:42
d4c23ae
to
3dbde5b
Compare
gevtushenko
added a commit
to NVIDIA/thrust
that referenced
this pull request
Aug 3, 2022
…ediate_type Fixing scan accumulator types for NVIDIA/cub#511
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
P1: should have
Necessary, but not critical.
release: breaking change
Include in "Breaking Changes" section of release notes.
testing: gpuCI passed
Passed gpuCI testing.
type: enhancement
New feature or request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue. It's based on the previous PR so the first commit might be skipped during this review.
AgentReduceByKey
now accepts accumulator type as the last template parameter.AgentScan
now accepts accumulator type as last template parameter.AgentScan::ConsumeRange
now acceptsprefix
as accumulator type instead of output iterator value type.AgentScanByKey
now accepts accumulator type as the last template parameter.DeviceReduceByKeyKernel
now accepts accumulator type as the last template parameter.DispatchReduceByKey
now accepts accumulator type as the last template parameter.DeviceScanKernel
now accepts accumulator type as the last template parameter.DeviceScanPolicy
now accepts accumulator type instead of output iterator value type.DispatchScan
now accepts accumulator type as a template parameter.DeviceScanByKeyKernel
now accepts accumulator type as a template parameter.DeviceScanByKeyPolicy
doesn't accept initial value type.DeviceScanByKeyPolicy
accepts accumulator type as a template parameter.DispatchScanByKey
now accepts accumulator type.