This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Deprecate TexRefInputIterator. #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DVS CL: 30058645 |
Opt-out for our internal builds, since we'll still need to maintain and test any deprecated APIs.
This class uses deprecated texture management CUDART APIs. The "Obj"-flavor uses non-deprecated CUDART APIs.
f919860 to
9c9fb93
Compare
| CUB_HOST_COMPILER == CUB_HOST_COMPILER_CLANG | ||
| #pragma GCC diagnostic push | ||
| #pragma GCC diagnostic ignored "-Wdeprecated-declarations" | ||
| #endif |
There was a problem hiding this comment.
We do this so that we don't trigger deprecation warnings in our own code, only when users use the deprecated facility, correct?
| // This class uses the deprecated cudaBindTexture / cudaUnbindTexture APIs. | ||
| // See issue NVIDIA/cub#191. | ||
| // Turn off deprecation warnings when compiling class implementation in favor | ||
| // of deprecating TexRefInputIterator instead. |
There was a problem hiding this comment.
I don't understand this comment, why "in favor of deprecating TexRefInputIterator"? Don't we disable warnings here so that they don't trigger in our own code, just on external usage?
There was a problem hiding this comment.
The internal usages of deprecated CUDART APIs are always suppressed, and instead we deprecate the CUB utilities that call them. So instead of emitting deprecation warnings for cudaBindTexture, etc, we deprecate cub::TexRefInputIterator directly.
brycelelbach
approved these changes
Jun 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class uses deprecated CUDART APIs. The improved replacement,
TexObjInputIterator, should be used instead. I'd like to get this in for 1.13.0 so folks get as much notice as possible.Also updated the deprecation mechanism to provide an opt-out, cmake options, and C++14 syntax. Our internal build will opt-out of deprecation warnings so we can continue to maintain and test deprecated APIs.