Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename sentinel.cuh -> types.cuh #452

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Conversation

sleeepyjack
Copy link
Collaborator

This PR renames include/cuco/sentinel.cuh to include/cuco/types.cuh as preparation work for #429. The goal is to have a single header containing all strong type used across cuco.

Note: Apparently Doxygen has become even pickier. I had to add some more inline docs to headers which we haven't touched in a while to get the pre-commit test to pass.

@sleeepyjack sleeepyjack added type: docs Improvements or additions to documentation Needs Review Awaiting reviews before merging type: improvement Improvement / enhancement to an existing function labels Apr 3, 2024
@sleeepyjack sleeepyjack self-assigned this Apr 3, 2024
@sleeepyjack sleeepyjack requested a review from PointKernel as a code owner April 3, 2024 01:11
@sleeepyjack sleeepyjack merged commit c620ce3 into NVIDIA:dev Apr 3, 2024
15 checks passed
@sleeepyjack sleeepyjack deleted the rename-types branch April 3, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Awaiting reviews before merging type: docs Improvements or additions to documentation type: improvement Improvement / enhancement to an existing function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants