Introduce cuco::cuda_stream_ref #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleeepyjack
commented
Apr 25, 2023
Comment on lines
+118
to
+137
| // /** | ||
| // * @brief Equality comparison operator for streams | ||
| // * | ||
| // * @param lhs The first stream view to compare | ||
| // * @param rhs The second stream view to compare | ||
| // * @return true if equal, false if unequal | ||
| // */ | ||
| // inline bool operator==(cuda_stream_ref lhs, cuda_stream_ref rhs) | ||
| // { | ||
| // return lhs.value() == rhs.value(); | ||
| // } | ||
|
|
||
| // /** | ||
| // * @brief Inequality comparison operator for streams | ||
| // * | ||
| // * @param lhs The first stream view to compare | ||
| // * @param rhs The second stream view to compare | ||
| // * @return true if unequal, false if equal | ||
| // */ | ||
| // inline bool operator!=(cuda_stream_ref lhs, cuda_stream_ref rhs) { return not(lhs == rhs); } |
There was a problem hiding this comment.
RMM defines these equality operators. However, they collide with the built-in ptr == ptr operator.
|
I would say we merge the current PR as a WAR and switch to |
PointKernel
approved these changes
Apr 25, 2023
|
Merging this to unblock the following PRs for set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a non-owning wrapper for
cudaStream_tcoinedcuco::cuda_stream_refand primarily borrows from RMM's implementation.