Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin importlib-resources #570

Closed
wants to merge 2 commits into from
Closed

pin importlib-resources #570

wants to merge 2 commits into from

Conversation

pstjohn
Copy link
Collaborator

@pstjohn pstjohn commented Jan 3, 2025 •
edited
Loading

Temporary pin for importlib-resources due to an undeclared dependency in a recently published version (this morning) in importlib-resources.

python/importlib_resources#323

@pstjohn
pin importlib-resources
64e19d4 
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
@pstjohn
Update requirements.txt
a09084b 
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
@pstjohn pstjohn added the SKIP_CI Completely skips the CI pipeline label Jan 3, 2025
@pstjohn
Copy link
Collaborator Author

pstjohn commented Jan 3, 2025

/build-ci

@pstjohn pstjohn enabled auto-merge (squash) January 3, 2025 18:43
trvachov
trvachov approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@trvachov trvachov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please just add the explicit keyword "TODO" here? otherwise lgtm.

@pstjohn
Copy link
Collaborator Author

pstjohn commented Jan 3, 2025

Fixed with new importlib version; no longer needed

@pstjohn pstjohn closed this Jan 3, 2025
auto-merge was automatically disabled January 3, 2025 21:50

Pull request was closed

@pstjohn pstjohn deleted the pstjohn-patch-1 branch January 17, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trvachov trvachov trvachov approved these changes

@dorotat-nv dorotat-nv Awaiting requested review from dorotat-nv dorotat-nv is a code owner

@jstjohn jstjohn Awaiting requested review from jstjohn jstjohn is a code owner

@malcolmgreaves malcolmgreaves Awaiting requested review from malcolmgreaves malcolmgreaves is a code owner

Assignees
No one assigned
Labels
SKIP_CI Completely skips the CI pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pstjohn @trvachov