fix: add support for passing calib sequence length, and num samples + fixing use of custom calibration dataset for smoothquant in llama #2243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue in the past code:
convert_checkpoint.py
. This is because:load_calib_dataset
function intensorrt_llm/models/convert_utils.py
has the default value of split and key set to be None. In the past, this function would work only for cnn_dailymail, lambada. But with better default values of "train" split and "text" key, this function would be able to load any dataset configured correctly.tensorrt_llm/models/llama/convert.py
.examples/llama/convert_checkpoint.py
.tensorrt_llm/models/llama/model.py
.Results:
With the above changes, to the release v0.12.0. I was able to check that the calibration works well with much better quality of quantized model in comparison to default calibration dataset. For SmoothQuant especially, when
per_token
is set to true, it is important that the calibration sequence length matches the distribution of the samples which are used during deployment/production.