Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in Fusion::print #3864

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Fix a bug in Fusion::print #3864

merged 1 commit into from
Feb 12, 2025

Conversation

wujingyue
Copy link
Collaborator

No description provided.

@wujingyue wujingyue requested a review from zasdfgbnm February 10, 2025 18:44
@wujingyue
Copy link
Collaborator Author

!test

Copy link

Description

  • Corrected output stream in Fusion::print method

Changes walkthrough 📝

Relevant files
Bug fix
fusion.cpp
Use `os` instead of `debug()` in Fusion::print                     

csrc/fusion.cpp

  • Replaced debug() with os for printing inputs
  • Replaced debug() with os for printing outputs
  • +4/-4     

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🧪 No relevant tests
    ⚡ Recommended focus areas for review

    Output Destination

    The code now prints inputs and outputs to os instead of debug(). Ensure that this change does not affect the intended logging behavior and that os is the correct destination for this output.

    os << "Inputs:" << std::endl;
    for (auto inp : inputs()) {
      os << "  " << inp << std::endl;
    }
    
    os << "Outputs:" << std::endl;
    for (auto out : outputs()) {
      os << "  " << out << std::endl;
    }

    @wujingyue wujingyue merged commit 7135a47 into main Feb 12, 2025
    54 checks passed
    @wujingyue wujingyue deleted the wjy/print branch February 12, 2025 00:22
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants