Introducing Block #1087
Merged
Introducing Block #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview |
Merged
edknv
reviewed
May 14, 2023
Comment on lines
+85
to
+86
| if self.accepts_batch: | ||
| if self.requires_batch: |
There was a problem hiding this comment.
Curious if these two lines can be collapsed into if self.accepts_batch and self.requires_batch and the rest of this code block be outdented once, or if it's due to quirks of Torchscript?
There was a problem hiding this comment.
It's so that if requires_batch is false, we cast Optional[Batch] into Batch and throw an RuntimeException if it's None.
This was referenced May 15, 2023
Merged
Merged
Merged
edknv
approved these changes
May 15, 2023
This was referenced May 16, 2023
Merged
26 tasks
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
First PR for the new PyTorch backend, this PR introduces the following user-facing classes:
BlockBatchSequenceAnd internal classes:
TorchScriptWrapperBlockContainerImplementation Details 🚧
TorchScriptWrappermakes it easier to work with torch-script. It will check the forward method and then stores various properties of it as constants. This way, torchscript doesn't need to worry about it.Testing Details 🔍
Since these are some of the lowest-level classes, I tried to maximize test-coverage as much as possible