Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install wheel package to enable legacy install method of LightFM package #1060

Merged
merged 3 commits into from
Apr 18, 2023

Conversation

oliverholworthy
Copy link
Member

Goals ⚽

Fixes installation of LightFM package following release of pip 23.1

Implementation Details 🚧

When the wheel package is not present, the legacy setup.py install no longer runs (pypa/pip#8559).

@oliverholworthy oliverholworthy added this to the Merlin 23.04 milestone Apr 17, 2023
@oliverholworthy oliverholworthy self-assigned this Apr 17, 2023
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1060

@oliverholworthy oliverholworthy requested a review from edknv April 17, 2023 20:12
@edknv edknv merged commit 17c1845 into NVIDIA-Merlin:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants