Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make horovod (2gpu) tests not required #1059

Closed
wants to merge 1 commit into from

Conversation

edknv
Copy link
Contributor

@edknv edknv commented Apr 17, 2023

This PR makes multi-gpu tests non-required to unblock CI. These tests run successfully when they are tested locally using the ci-runner image and tox so the current failures are most likely due to hardware issues. We can make them required again in the future if needed.

@edknv edknv self-assigned this Apr 17, 2023
@edknv edknv added ci chore Maintenance for the repository labels Apr 17, 2023
@edknv edknv added this to the Merlin 23.04 milestone Apr 17, 2023
@edknv edknv marked this pull request as ready for review April 17, 2023 15:56
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1059

@edknv
Copy link
Contributor Author

edknv commented Apr 17, 2023

We have different errors blocking each other, and this PR is blocked by fixing test_synthetic_aliccp_raw_data. The change in this PR will have to be combined into one of the PRs that fix test_synthetic_aliccp_raw_data: #1056 or #1057.

@edknv edknv closed this Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance for the repository ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant