Restoring tox.ini and .github/workflows/tensorflow.yml #1023
Conversation
Documentation preview |
2b7c5af to
8ecefb1
Compare
| # Enforcing the PR that implements the dataloader features changes | ||
| #python -m pip install --upgrade git+https://github.com/NVIDIA-Merlin/dataloader.git@{posargs:main} | ||
| python -m pip install --upgrade git+https://github.com/bschifferer/dataloader.git@change_output | ||
| python -m pip install --upgrade git+https://github.com/NVIDIA-Merlin/dataloader.git@{posargs:main} |
There was a problem hiding this comment.
We might need to add --no-deps to each of these pip installs of merlin packages to avoid the subsequent pip installs changing the version of a previous merlin package
There was a problem hiding this comment.
Thanks @oliverholworthy . I agree.
My concern is if we use --no-deps here it won't install none of the dependencies, including external PyPy packages. Could we assume that external packages are already installed in the container (so that we can use --no-deps)?
There was a problem hiding this comment.
I think it's safe to do --no-deps because the merlin packages installed here (e.g. the dataloader) are already part of the Merlin Models package requirements which get installed as part of every tox environment by default.
My understanding is that main reason we have these lines here is to override the version that's installed for the release branch builds.
…nges done to run CI on a specific dataloader branch
8ecefb1 to
08f814c
Compare
Goals ⚽
Restoring tox.ini and .github/workflows/tensorflow.yml to reverse changes done to run models CI on a specific dataloader branch