-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nightly container builds #518
Conversation
Our nightly container builds are failing, because all the integration tests are skipped (since we don't have faiss/feast on the containers). pytest returns error code '5' in this case, causing us to fail the container. Use the workaround as suggested pytest-dev/pytest#2393 (comment)
Documentation preview |
The problem on the nightly TF build: root@93e5a5ef4e09:/Merlin# pytest -rxs tests/integration
================================================= test session starts ==================================================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /Merlin
plugins: anyio-3.6.1
collected 0 items / 1 skipped
=============================================== short test summary info ================================================
SKIPPED [1] tests/integration/examples/test_ci_building_deploying_multi_stage_RecSys.py:10: could not import 'feast': No module named 'feast'
================================================== 1 skipped in 2.11s ==================================================
root@93e5a5ef4e09:/Merlin# echo $?
5 After this fix, the error code is changed to 0 instead of 5 |
Click to view CI ResultsGitHub pull request #518 of commit d91e4503c0d5b79e6337c955fe44ab77c9f5ab22, no merge conflicts. Running as SYSTEM Setting status of d91e4503c0d5b79e6337c955fe44ab77c9f5ab22 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/318/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/518/*:refs/remotes/origin/pr/518/* # timeout=10 > git rev-parse d91e4503c0d5b79e6337c955fe44ab77c9f5ab22^{commit} # timeout=10 Checking out Revision d91e4503c0d5b79e6337c955fe44ab77c9f5ab22 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f d91e4503c0d5b79e6337c955fe44ab77c9f5ab22 # timeout=10 Commit message: "Fix nightly container builds" > git rev-list --no-walk 550aeb40387b2e4ff05da58b0905360fcb34dd70 # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins15632308793292706780.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
rerun tests |
Click to view CI ResultsGitHub pull request #518 of commit d91e4503c0d5b79e6337c955fe44ab77c9f5ab22, no merge conflicts. Running as SYSTEM Setting status of d91e4503c0d5b79e6337c955fe44ab77c9f5ab22 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/319/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/518/*:refs/remotes/origin/pr/518/* # timeout=10 > git rev-parse d91e4503c0d5b79e6337c955fe44ab77c9f5ab22^{commit} # timeout=10 Checking out Revision d91e4503c0d5b79e6337c955fe44ab77c9f5ab22 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f d91e4503c0d5b79e6337c955fe44ab77c9f5ab22 # timeout=10 Commit message: "Fix nightly container builds" > git rev-list --no-walk d91e4503c0d5b79e6337c955fe44ab77c9f5ab22 # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins12620503681835000123.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
Our nightly container builds are failing, because all the integration tests are skipped
(since we don't have faiss/feast on the containers). pytest returns error code '5'
in this case, causing us to fail the container.
Use the workaround as suggested pytest-dev/pytest#2393 (comment)