Additional converters for floordiv, mod, ne, and torch::tensor() operations #505
Conversation
…ps for relu and sigmoid.
…tend relu and sigmoid converters to Tensor methods.
|
Hi @meremeev, Thanks for this pull request! I took a quick glance, this looks nice! I look forward to testing these features and getting back. Out of curiosity, were these additions inspired by a particular use case / model? If so I'm interested to hear what this might be to better understand how you're using (or hoping to use) torch2trt. Best, |
|
Hi @meremeev , I've tested the changes, they seem to work well, and other functions are behaving as expected. I think this is good to merge. I would only suggest that we add entries to the CHANGELOG under master just to help establish the practice in this project. https://github.com/NVIDIA-AI-IOT/torch2trt/blob/master/CHANGELOG.md Let me know if you're interested in adding the entries. Otherwise, I'm happy to add them. Best, |
|
Hi John, At Luminar we are considering using torch2trt package to convert our semantic segmentation model to TensorRT engine.. These converters are what we need to make it working. I will update CHANGELOG.md shortly. Thank you, |
|
Done
…On Fri, Feb 19, 2021 at 4:49 PM John ***@***.***> wrote:
Hi @meremeev <https://github.com/meremeev> ,
I've tested the changes, they seem to work well, and other functions are
behaving as expected.
I think this is good to merge. I would only suggest that we add entries to
the CHANGELOG
<https://github.com/NVIDIA-AI-IOT/torch2trt/blob/master/CHANGELOG.md>
under master just to help establish the practice in this project.
https://github.com/NVIDIA-AI-IOT/torch2trt/blob/master/CHANGELOG.md
Let me know if you're interested in adding the entries. Otherwise, I'm
happy to add them.
Best,
John
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#505 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHC4D5BQLJFW66TUKOBNRVDS74BHXANCNFSM4X32AWTA>
.
|
|
Looks great @meremeev, thanks! Will merge this now. Please feel free to reach out with any other issues / pull request / general discussion , etc. Thanks again, |
…ations (#505) * Initioal version of ne, floordiv, mod and tensor converters. Extend ops for relu and sigmoid. * Converters for floordiv, mod, ne, and torch::tensor() operations . Extend relu and sigmoid converters to Tensor methods. * Update CHANGELOG.md
No description provided.