Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getStigById/getUserByUserId now return 404 when querying a resource that does not exist. #1358

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

Matte22
Copy link
Collaborator

@Matte22 Matte22 commented Aug 30, 2024

getStigById/getUserByUserId were returning a empty 200 response body when querying a resource that does not exist. This was found through the validation response workflow. This PR alters these endpoints to now return a 404.

Copy link

Quality Gate Passed Quality Gate passed for 'nuwcdivnpt_stig-manager-api'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
25.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@csmig csmig added the API label Aug 30, 2024
@csmig csmig merged commit aaa6708 into main Aug 30, 2024
10 checks passed
@csmig csmig deleted the responseValidationFix branch August 30, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants