-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/minor issues clean up #78
Conversation
Azure Static Web Apps: Your stage site is ready! Visit it here: https://gray-river-017c6bf1e-78.westus2.azurestaticapps.net |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://gray-river-017c6bf1e-78.westus2.azurestaticapps.net |
Same thoughts here lol. |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://gray-river-017c6bf1e-78.westus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://gray-river-017c6bf1e-78.westus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://gray-river-017c6bf1e-78.westus2.azurestaticapps.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this branch in person and added some useless elements.
Huge thanks for the efforts you put in refactoring this. 😍
Azure Static Web Apps: Your stage site is ready! Visit it here: https://gray-river-017c6bf1e-78.westus2.azurestaticapps.net |
MediaQuery
(useMediaQuery does not work with SSR styles chakra-ui/chakra-ui#2827) to avoid client side rerender when using mobile view in SSR mode. Most ofuseMediaQuery
can be replaced by inline CSS syntax such as{base: "10px", md: "20px"}
. Some mediaQuery can't be replaced by css syntax above (because ChakraUI does not let certain props likesize
of button receive these responsive value ), so I useuseBreakpointValue
hook recommended by ChakraUI to replacemediaQuery
. (However I thinkuseMediaQuery
&useBreakpointValue
have no difference 🤣. They both render default css value first and rerender if it detect it's mobile view. )renderSomthingFunnction = () => <>...</>
so the component won't re-create on every render) & remove some unused code