Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vacuum #17

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Add vacuum #17

merged 5 commits into from
Sep 24, 2024

Conversation

awalter-bnl
Copy link
Contributor

This PR adds the discussed change to how vacuum components are included (see code snippet below for the new structure). It also makes a few back-end changes to how 'print' and 'tab-to-complete' code works but these do not affect the User Interface.

@Jiemin-Li please take a look when you get a chance. @tfg4280 you may also want to take a look as you start to get your head around this work (suggestions/ comments are welcome).

In [3]: print(m1)

m1 ('device')
  "positions":    locations 
  "motors":    Ry_coarse     Ry_fine     Rz     x     y 
  "devices":    
    vacuum 
      "sections":    
        AriSxnC 
          "detectors":    ccg     tcg     ip 
          "positions":    gv     
    slits 
      "positions":    locations 
      "motors":    top     bottom     inboard     outboard 
      "detectors":    currents     
    diag 
      "positions":    locations 
      "motors":    blade     filter 
      "detectors":    camera     currents 

@awalter-bnl awalter-bnl requested a review from Jiemin-Li August 15, 2024 13:49
Copy link
Contributor

@Jiemin-Li Jiemin-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current structure for m1 section is clear to me, especially when printing it in Bluesky,.

@Jiemin-Li Jiemin-Li merged commit 13892fc into NSLS-II-ARI:main Sep 24, 2024
@awalter-bnl awalter-bnl deleted the add_vacuum branch September 24, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants