Add Gatevalve object #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing a reference to m1 called M1 so use of either is equivalent
Jiemin-Li
reviewed
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the M1 gatevalve to the M1 mirror object as well as removing the
ari_ophyd.M1class from the namespace when running 'bluesky_test_setup.py' and instead creating a reference to them1object from theM1name so either can be used interchangeably. This is accompanied by the similar PR#15 to NSLS-II-ARI/ARI_SXN_SimBeamline which adds the appropriate PV's to theari_sxn_simbeamline.caproto_servers.ARIM1PVGroup.@Jiemin-Li and @wen-hu please take a look.