Update prettystr and reduce the number of options when tab-to-completing #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ict the options to signals and the read method
…mvr bluesky.plan_stubs. I also added move and move_relative as aliases to mv and mvr with more descriptive names
|
@Jiemin-Li , @wen-hu sorry for the new pushes but I decided to extend the number of built-in plans loaded to all of them. I also added mv and mvr, I also wanted to add some non-abbreviated versions so I went with move, rel_move and relative_move as this matches the naming convention for built-in scans. |
Jiemin-Li
reviewed
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-factors the
PrettyStrclass into two:PrettyStrForDevices, andPrettyStrForSignals. The first is used when the ophyd object in question has childsignalsthat should be included in the 'print' and the second for when childsignalsshould not be included.In addition this PR adds a custom
__dir__()method to both of these classes to only show thereadmethod and the child signals when doing tab-to-complete. This is meant to aid users by only showing items that they will need to access and hence removing confusion.Finally it also includes some updates to some docstrings as they had gotten out of date with the significant number of recent PR merges.
@wen-hu and @Jiemin-Li please take a look and provide comments