Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sdist #9

Merged
merged 1 commit into from
Oct 31, 2023
Merged

fix sdist #9

merged 1 commit into from
Oct 31, 2023

Conversation

nreinicke
Copy link
Collaborator

@nreinicke nreinicke commented Oct 31, 2023

Applies some small changes to fix the source distribution.

Building the source distribution with this fix: PyO3/maturin#1828 correctly includes the routee-compass-py member in the resulting Cargo.toml file that gets placed in the sdist, allowing someone to install the package from distribution. For now, we can manually upload our source distributions and hopefully just point to an updated version of maturin with the fix applied for future builds.

I've also updated the pyproject.toml file to include the default config files for OSM and exclude the onnx runtime files.

I tagged this version as release v0.2.0.post1 since the code hasn't changed, we're just correcting the source distribution. (see here)

@robfitzgerald if this looks okay to you I'll proceed with the manual PyPI release after we merge this.

Closes #7

Copy link
Collaborator

@robfitzgerald robfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right, I'll just give this a 👍 from my phone here so you can finish the job. Thanks for taking care of this!

@nreinicke nreinicke merged commit d0786b3 into main Oct 31, 2023
@nreinicke nreinicke deleted the release/v0.2.0.post1 branch October 31, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip install fails with "current package believes it's in a workspace when it's not"
2 participants