Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arbitrary flow field point probing support #641

Closed
wants to merge 29 commits into from

Conversation

paulf81
Copy link
Collaborator

@paulf81 paulf81 commented Apr 27, 2023

Not yet ready to merge

Add ability to get velocity at arbitrary points

This branch, based on the branch on @rafmudaf adds the ability to collect the velocity at arbitrary points in space, based on the the new PointsGrid class. The feature is meant to be similar in some ways to visualization methods, but avoids duplicate calls to underlying turbine grid solvers such that adding a few test points should not substantially slow down computation as adding a whole plane of points would.

Further, the method seems to enable simplification of the code in that other visualization methods could be converted to be effectively wrappers to this call passed in differently oriented planes of points, or even volumes.

Currently also includes 3-4 additional examples but this number may change as we get nearer a final version.

Still to go:

  • Resolve issue that turbines apparently move when wind direction changes
  • Add examples to directly test that wake is where we'd think by using farm layouts more complicated than lines
  • Confirm works with at least most models (GCH/empirical/Jensen)
  • Convert planar visualizations to be wrappers?
  • Clean up things

Related issue

@paulf81 paulf81 added the enhancement An improvement of an existing feature label Apr 27, 2023
@paulf81 paulf81 added this to the v3.4 milestone Apr 27, 2023
@paulf81 paulf81 requested review from bayc, rafmudaf and misi9170 April 27, 2023 19:51
@paulf81
Copy link
Collaborator Author

paulf81 commented May 4, 2023

@misi9170 in your email you mentioned you might have a little reconciliation to go with the work of @bayc and @Bartdoekemeijer , just wanted to check if that is included in the commit above, or if I should wait? thanks!

@misi9170
Copy link
Collaborator

misi9170 commented May 4, 2023

@misi9170 in your email you mentioned you might have a little reconciliation to go with the work of @bayc and @Bartdoekemeijer , just wanted to check if that is included in the commit above, or if I should wait? thanks!

@paulf81 Thanks for making a note of that. Those reconciliations are not currently included. Just to record our discussion from earlier, let's plan to get the other PR (#578) into develop first; then I'll merge develop and deal with the merge conflicts. @bayc did a bit of work on #578 this morning to make sure it'll be ready to accept this PR with minimal changes.

@paulf81
Copy link
Collaborator Author

paulf81 commented May 4, 2023

@misi9170 in your email you mentioned you might have a little reconciliation to go with the work of @bayc and @Bartdoekemeijer , just wanted to check if that is included in the commit above, or if I should wait? thanks!

@paulf81 Thanks for making a note of that. Those reconciliations are not currently included. Just to record our discussion from earlier, let's plan to get the other PR (#578) into develop first; then I'll merge develop and deal with the merge conflicts. @bayc did a bit of work on #578 this morning to make sure it'll be ready to accept this PR with minimal changes.

Sounds great, thank you!

@rafmudaf rafmudaf changed the title Add ability to get velocity at arbitrary points Add arbitrary flow field point probing support May 5, 2023
@rafmudaf
Copy link
Collaborator

rafmudaf commented May 8, 2023

@paulf81 @misi9170 is this ready for review? If so, please change it from "draft" to "ready for review". Also, the tests are failing so that should be addressed asap.

@misi9170
Copy link
Collaborator

misi9170 commented May 8, 2023

@paulf81 @misi9170 is this ready for review? If so, please change it from "draft" to "ready for review". Also, the tests are failing so that should be addressed asap.

Thanks @rafmudaf. I'll look into this now and provide an update shortly.

@misi9170
Copy link
Collaborator

misi9170 commented May 8, 2023

This pull request has now been replaced by #650.

@rafmudaf
Copy link
Collaborator

Replaced by #650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants