-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arbitrary flow field point probing support #641
Conversation
This is ultimately used to construct the `power_interp` array, so it is redundant here.
# Conflicts: # floris/simulation/farm.py # floris/simulation/turbine.py # tests/turbine_unit_test.py
@misi9170 in your email you mentioned you might have a little reconciliation to go with the work of @bayc and @Bartdoekemeijer , just wanted to check if that is included in the commit above, or if I should wait? thanks! |
@paulf81 Thanks for making a note of that. Those reconciliations are not currently included. Just to record our discussion from earlier, let's plan to get the other PR (#578) into develop first; then I'll merge develop and deal with the merge conflicts. @bayc did a bit of work on #578 this morning to make sure it'll be ready to accept this PR with minimal changes. |
Sounds great, thank you! |
# Conflicts: # floris/simulation/floris.py
This pull request has now been replaced by #650. |
Replaced by #650 |
Not yet ready to merge
Add ability to get velocity at arbitrary points
This branch, based on the branch on @rafmudaf adds the ability to collect the velocity at arbitrary points in space, based on the the new PointsGrid class. The feature is meant to be similar in some ways to visualization methods, but avoids duplicate calls to underlying turbine grid solvers such that adding a few test points should not substantially slow down computation as adding a whole plane of points would.
Further, the method seems to enable simplification of the code in that other visualization methods could be converted to be effectively wrappers to this call passed in differently oriented planes of points, or even volumes.
Currently also includes 3-4 additional examples but this number may change as we get nearer a final version.
Still to go:
Related issue