Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ca develop #15

Merged
merged 14 commits into from
May 1, 2020
Merged

Ca develop #15

merged 14 commits into from
May 1, 2020

Conversation

lisa-bengtsson
Copy link
Collaborator

Cellular automata updates to be able to run global and sub-grid CA's at the same time, improvements for stochastic convection representation, some cleaning. Updates are dependent upon updates in submodules FV3 and ccpp/physics.

Copy link
Collaborator

@pjpegion pjpegion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I code changes look good. Just to confirm, this will also require an update to fv3_atm? If so, I will hold off doing the merge until that gets coordinated with Jun.

@lisa-bengtsson
Copy link
Collaborator Author

I code changes look good. Just to confirm, this will also require an update to fv3_atm? If so, I will hold off doing the merge until that gets coordinated with Jun.

That is correct. Let me know if I can help with that coordination somehow.

@climbfuji
Copy link
Collaborator

I can take care of that. We currently have it scheduled for April 14.

@climbfuji
Copy link
Collaborator

ra = 201
rb = 2147483648
rc = 4294967296

halo=1
k_in=1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest a code block such as:
if (nlev .EQ. 64) then
k350=29
k850=13
else (nlev. EQ. 127) then
k350=61
k850=28
else ! make a guess
k350=nint(nlev/2)
k850=nint(nlev/5)
print*,'this level selection is not supported, making an approximation for k350 and k850'
endif

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good suggestion!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I addressed this and results are reproduced.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good, once you commit and push the updates, I can do the merge.

Copy link
Collaborator

@pjpegion pjpegion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see in cellular_automata_sgs.F90 you have 850 hPa and 350 hPa hardcoded for the 64 level version of the model. I don't think it needs to be generic, but it needs to have support for the 127 level version. I put a suggestion in the comments section of that file.

Copy link
Collaborator

@pjpegion pjpegion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and will be merged in.

@pjpegion pjpegion merged commit bb5bd06 into NOAA-PSL:psd/develop May 1, 2020
@pjpegion pjpegion mentioned this pull request May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants